-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Emoji] Add the text locale #19919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javiereguiluz
merged 1 commit into
symfony:7.1
from
alamirault:feature/54470-add-text-locale
May 30, 2024
Merged
[Emoji] Add the text locale #19919
javiereguiluz
merged 1 commit into
symfony:7.1
from
alamirault:feature/54470-add-text-locale
May 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
May 30, 2024
@@ -561,6 +561,7 @@ textual representation in all languages based on the `Unicode CLDR dataset`_:: | |||
|
|||
The ``EmojiTransliterator`` also provides special locales that convert emojis to | |||
short codes and vice versa in specific platforms, such as GitHub, Gitlab and Slack. | |||
All theses platform are also combined in special locale ``text``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
All theses platform are also combined in special locale ``text``. | |
All theses platform are also combined in special ``text`` locale. |
OskarStark
approved these changes
May 30, 2024
1e554a2
to
0074962
Compare
Thanks Antoine. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 5, 2024
…uiluz) This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [String] Update the emoji transliteration docs After merging #19919, I thought about some tweaks and updates that we could do in these docs. Commits ------- 8be7bb3 [String] Update the emoji transliteration docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19745
(No versionadded because, emoji component was introduced in 7.1)