Prepare 7.2 branch #19915
Merged
Prepare 7.2 branch #19915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jun 7, 2024
| @@ -48,10 +48,10 @@ application: | |||
| .. code-block:: terminal | |||
|
|
|||
| # run this if you are building a traditional web application | |||
| $ symfony new my_project_directory --version="7.1.*" --webapp | |||
| $ symfony new my_project_directory --version="7.2.*" --webapp | |||
There was a problem hiding this comment.
I tried this command and it doesn't work:
❯ symfony new my_project_directory --version="7.2.*" --webapp
In CreateProjectCommand.php line 424:
Could not find package symfony/skeleton with version 7.2.*.
These other two commands worked as expected:
❯ symfony new my_project_directory --version="7.2.x-dev" --webapp
Creating a new Symfony 7.2.x-dev project with Composer
[...]
❯ symfony new my_project_directory --version=next --webapp
Creating a new Symfony 7.2.x@dev project with Composer
[...]
There was a problem hiding this comment.
Would you agree on using --version=next here? That way, we wouldn't have to update this in the dev branch of Symfony Docs ... but we'd need to update it back to an specific constraint version whenever a new minor Symfony version is released.
There was a problem hiding this comment.
At the end I used 7.2.x-dev because we need to use that in Composer commands (next doesn't work there). This way, we use 7.2.x-dev everywhere and this will be easier to maintain in the future.
|
Thanks Antoine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.