Skip to content

Add documentation for #[MapUploadedFile] attribute #19807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

renedelima
Copy link
Contributor

@renedelima renedelima commented Apr 19, 2024

Closes #19802

@carsonbot carsonbot added this to the 7.1 milestone Apr 19, 2024
@OskarStark OskarStark changed the title Add documentation for #[MapUploadedFile] attribute Add documentation for #[MapUploadedFile] attribute Apr 19, 2024
@renedelima renedelima force-pushed the map-uploaded-file branch 17 times, most recently from 15e622c to 2b78938 Compare April 20, 2024 09:27
@renedelima
Copy link
Contributor Author

renedelima commented Apr 20, 2024

@OskarStark I applied your suggestions, fixed the Code blocks check, and made some other changes. The PR is now ready for review.

@renedelima renedelima force-pushed the map-uploaded-file branch 5 times, most recently from 5f01462 to 2760f35 Compare April 22, 2024 18:58
@mttsch
Copy link
Contributor

mttsch commented Apr 22, 2024

Should the attribute also be added to https://symfony.com/doc/7.1/reference/attributes.html#httpkernel?

@renedelima renedelima force-pushed the map-uploaded-file branch 7 times, most recently from c595ebc to 5cd1964 Compare April 22, 2024 20:32
@renedelima
Copy link
Contributor Author

Should the attribute also be added to https://symfony.com/doc/7.1/reference/attributes.html#httpkernel?

The link was added.

@javiereguiluz javiereguiluz merged commit 630cac8 into symfony:7.1 May 8, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Renê, thanks a lot for adding these docs ... and congrats on your first Symfony Docs contribution 🎉

What a beautiful contribution you did to Symfony code (and docs too!). Tomorrow I'll publish a "New in Symfony 7.1" post dedicated to this.

Note: while merging I did some tweaks and rewords. See 846cbae. It looks like I changed a ton of things, but it's not true:

  • I changed the order to display first the simple example with no constraints
  • I changed the style of the controllers to show a standard controller extending AbstractController instead of an invokable controller (your original example is perfectly correct, but this article is one of the basic chapters of Symfony Docs, so I prefer to keep the same basic style as in the rest of the page)
  • Other minor tweaks

So, most of your contribution stays. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpKernel] Introduce #[MapUploadedFile] controller argument attribu…
6 participants