[Validator] feat: add warning for number constraints with PHP 7.x #19765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
feat-add-warning-for-number-constraints-with-PHP-7.x
branch
from
d4cce57 to
da967e3
Compare
alexislefebvre
force-pushed
the
feat-add-warning-for-number-constraints-with-PHP-7.x
branch
from
da967e3 to
7341079
Compare
xabbuh
approved these changes
Apr 9, 2024
carsonbot
changed the title
|
Thank you Alexis. |
alexislefebvre
deleted the
feat-add-warning-for-number-constraints-with-PHP-7.x
branch
OskarStark
added a commit
that referenced
this pull request
Apr 17, 2024
…ebvre) This PR was merged into the 5.4 branch. Discussion ---------- fix warning for number constraints with PHP 7.x Fixes display issue on https://symfony.com/doc/5.x/reference/constraints/Positive.html >  `integer` is not displayed as code. - Follow-up of #19765 Commits ------- 02e88f1 Update _php7-string-and-number.rst.inc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#45710
See:
Symfony 6.x requires PHP 8.x and it fixes this inconsistency, see symfony/symfony#45710 (comment)
So this patch should be removed when merging
5.4in6.0(or6.4).