Skip to content

[Process] create_new_console option only on Windows #19591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

thomas-l
Copy link
Contributor

No description provided.

@thomas-l
Copy link
Contributor Author

thomas-l commented Feb 23, 2024

I'm not sure whether it has always been the case for older versions of PHP proc_open function. Tell me if I should anyway make a PR against the oldest branch with the options.

@javiereguiluz
Copy link
Member

Thomas, thanks and congrats on your first Symfony Docs contribution 🎉

I wasn't aware of this limitation, so it's a good idea to mention it explicitly in the docs.
Note that while merging, I expanded your original caution a bit more to explain more in detail this limitation (See c9e0e92).

Finally, we merged this in 5.4 branch and all the upper maintained branches. Thanks!

@thomas-l
Copy link
Contributor Author

I was in a rush and did not manage to expand my short caution in a decent way! I'll take the time to do better next time 😊

@thomas-l thomas-l deleted the patch-1 branch February 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants