Skip to content

Changed wrong argument names #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2012

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 23, 2012

As twig will support named arguments soon

@weaverryan
Copy link
Member

@wouterj thanks for doing this, but I think that this may undo your changes to reference/twig_reference.rst where you added some labels to

:ref:`the Twig Form reference<reference-forms-twig-errors>`"

Can you confirm?

Thanks!

As twig will support named arguments soon
@wouterj
Copy link
Member Author

wouterj commented Nov 23, 2012

@weaverryan well, I started from scratch now, as a simple git rebase wasn't the solution. I have updated the branch and it should be correct now.

How about the twig examples?

weaverryan added a commit that referenced this pull request Nov 26, 2012
@weaverryan weaverryan merged commit c8e1d56 into symfony:2.0 Nov 26, 2012
@weaverryan
Copy link
Member

Looks great!

@wouterj wouterj deleted the correct_named_twig_arguments branch December 31, 2012 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants