Skip to content

Fix broken reference links #19515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix broken reference links #19515

merged 1 commit into from
Feb 6, 2024

Conversation

alamirault
Copy link
Contributor

I found them with tweaked docs-builder, but it took a very long time

I will check other branches when this one will be merged

@alamirault alamirault requested a review from xabbuh as a code owner February 5, 2024 19:41
@carsonbot carsonbot added this to the 5.4 milestone Feb 5, 2024
@alamirault alamirault force-pushed the hotfix/broken-links-54 branch from 292036a to c9487e3 Compare February 5, 2024 19:51
OskarStark
OskarStark reviewed Feb 5, 2024
View reviewed changes
components/cache/adapters/pdo_adapter.rst
@@ -41,7 +41,7 @@ your code.
.. deprecated:: 5.4

Using :class:`Symfony\\Component\\Cache\\Adapter\\PdoAdapter` with a
:class:`Doctrine\\DBAL\\Connection` or a DBAL URL is deprecated since Symfony 5.4
``Doctrine\DBAL\Connection`` or a DBAL URL is deprecated since Symfony 5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a link?

@javiereguiluz
Copy link
Member

Thanks a lot Antoine. I'm sorry this took you a long time ... but at least it's much appreciated 🙇

@javiereguiluz javiereguiluz merged commit d0ca89f into symfony:5.4 Feb 6, 2024
@alamirault alamirault mentioned this pull request Feb 6, 2024
Merged
javiereguiluz added a commit that referenced this pull request Feb 7, 2024
@javiereguiluz
minor #19523 Fix broken class links (alamirault)
8aa1148 
This PR was merged into the 6.4 branch.

Discussion
----------

Fix broken class links

Continue #19515 on 6.4 branch

Commits
-------

c4023a6 Fix broken class links
@alamirault alamirault mentioned this pull request Feb 8, 2024
Merged
OskarStark added a commit that referenced this pull request Feb 8, 2024
@OskarStark
minor #19535 Fix broken class links (alamirault)
18d3694 
This PR was merged into the 7.1 branch.

Discussion
----------

Fix broken class links

Continue #19515 on 7.1 branch

Commits
-------

ebd373c Fix broken class links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @javiereguiluz @OskarStark @carsonbot