Update console.rst #19191
Merged
Update console.rst #19191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Nov 28, 2023
|
In the Symfony Demo app we recently had to do this change to fix some PHPStan issue: symfony/demo@b9b47c7 |
theofidry
approved these changes
Dec 8, 2023
| self::bootKernel(); | ||
| $application = new Application(self::$kernel); |
There was a problem hiding this comment.
maybe we could go a step further?
Suggested change
| self::bootKernel(); | |
| $application = new Application(self::$kernel); | |
| $application = new Application(self::bootKernel()); |
|
I am not sure we should worry about PHPStan here however, the variable type is documented correctly and PHPStan does not come with Symfony by default. |
remove $kernel variable
|
Thank you @hbgamra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove $kernel variable