[Workflow] Mention the workflow.marking_store.service option
#19129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
workflow-service-marking-store
branch
2 times, most recently
from
885aba2 to
e2a0b7f
Compare
lyrixx
reviewed
Nov 13, 2023
workflow.rst
Outdated
Comment on lines
832
to
842
| /** | ||
| * @var string | ||
| */ | ||
| private $property; | ||
|
|
||
| public function __construct(string $property = 'property') | ||
| { | ||
| $this->property = $property; | ||
| } | ||
|
|
||
| public function getMarking(object $subject): Marking | ||
| { | ||
| $r = new \ReflectionObject($subject); | ||
| $property = $r->getProperty($this->property); | ||
|
|
||
| return new Marking([$property->getValue($subject) => 1]); | ||
| } | ||
|
|
||
| public function setMarking(object $subject, Marking $marking): void | ||
| { | ||
| $r = new \ReflectionObject($subject); | ||
| $property = $r->getProperty($this->property); | ||
|
|
||
| $property->setValue($subject, $marking); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would simplify this a lot
- Don't use the reflection
- hardcode the property
- typehint with this real object
Since this is an example, we don't need to abstract things
There was a problem hiding this comment.
Good idea! That's updated 🙂
alexandre-daubois
force-pushed
the
workflow-service-marking-store
branch
from
e2a0b7f to
ceaf2c8
Compare
OskarStark
reviewed
Nov 13, 2023
workflow.rst
Outdated
| use Symfony\Component\Workflow\Marking; | ||
| use Symfony\Component\Workflow\MarkingStore\MarkingStoreInterface; | ||
|
|
||
| class BlogPostMarkingStore implements MarkingStoreInterface |
There was a problem hiding this comment.
Suggested change
| class BlogPostMarkingStore implements MarkingStoreInterface | |
| final class BlogPostMarkingStore implements MarkingStoreInterface |
OskarStark
approved these changes
Nov 13, 2023
alexandre-daubois
force-pushed
the
workflow-service-marking-store
branch
from
ceaf2c8 to
175807f
Compare
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered this option when trying to implement an enum marking store and make it work. The
serviceoption is indeed referenced here: https://symfony.com/doc/current/reference/configuration/framework.html#marking-store but it isn't explained how to use it. I propose to add this section which could help a lotFriendly ping @lyrixx if you'd like to check 🙂