[FrameworkBundle][HttpKernel] Introduce $buildDir argument to WarmableInterface::warmup to warm read-only artefacts in build_dir
#19041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 18, 2023
reference/dic_tags.rst
Outdated
| If you don't need to preload anything, return an empty array. | ||
| If you don't need to preload anything, return an empty array. If read-only | ||
| artefacts need to be created, you can store them in a different directory | ||
| with the ``buildDir`` argument of the ``warmUp()`` method. |
Contributor
There was a problem hiding this comment.
Suggested change
| with the ``buildDir`` argument of the ``warmUp()`` method. | |
| with the ``$buildDir`` argument of the ``warmUp()`` method. |
Not sure if we should use argument or parameter here
Member
Author
There was a problem hiding this comment.
Let's use parameter everywhere 🙂
OskarStark
reviewed
Oct 18, 2023
reference/dic_tags.rst
Outdated
|
|
||
| .. versionadded:: 6.4 | ||
|
|
||
| The ``buildDir`` argument of the |
Contributor
There was a problem hiding this comment.
Suggested change
| The ``buildDir`` argument of the | |
| The ``$buildDir`` parameter of the |
OskarStark
approved these changes
Oct 18, 2023
Contributor
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
A function signature contains parameters and is called with arguments
…ableInterface::warmup` to warm read-only artefacts in `build_dir`
alexandre-daubois
force-pushed
the
warmup-build-dir
branch
from
efdd2de to
2026c73
Compare
Member
Author
|
Good rule of thumb, I always get the two mixed up 😅 |
Contributor
|
Thank you Alexandre. |
Contributor
|
Thank you @alexandre-daubois ! It was on my todo-list for today, but you beat me to it 😅 |
Member
Author
|
Oops, my bad! I'll ask you next time so you can take the time to do it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19034