[Routing] Add FQCN and FQCN::method aliases when applicable #18822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Sep 4, 2023
routing.rst
Outdated
|
|
||
| class MainController extends AbstractController | ||
| { | ||
| #[Route('/', name: 'homepage', stateless: true)] |
There was a problem hiding this comment.
the stateless is not important here, isn't it?
There was a problem hiding this comment.
That's right, updated 👍
OskarStark
reviewed
Sep 4, 2023
routing.rst
Outdated
| use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; | ||
| use Symfony\Component\Routing\Annotation\Route; | ||
|
|
||
| class MainController extends AbstractController |
There was a problem hiding this comment.
Suggested change
| class MainController extends AbstractController | |
| final class MainController extends AbstractController |
alexandre-daubois
force-pushed
the
route-alias
branch
from
7410fcc to
e518a88
Compare
|
Alex, thanks for contributing this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18437