Skip to content

[Lock] Blocking locks example #18796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

[Lock] Blocking locks example #18796

merged 1 commit into from
Aug 30, 2023

Conversation

simoheinonen
Copy link
Contributor

Redis store doesn't support blocking so doesn't make sense to use it as an example

@simoheinonen
Update lock.rst
dbb7f85 
Redis store doesn't support blocking so doesn't make sense to use it as an example
@carsonbot carsonbot added this to the 5.4 milestone Aug 29, 2023
@simoheinonen simoheinonen changed the title Blocking locks example [Lock] Blocking locks example Aug 29, 2023
@javiereguiluz
Copy link
Member

Good catch Simo! This very same article lists Redis locks as "not blocking", so we must fix this example. Thanks!

@javiereguiluz javiereguiluz merged commit c3b7325 into symfony:5.4 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Lock Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@simoheinonen @javiereguiluz @carsonbot