[AssetMapper] Add docs for importmap:install command
#18785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Aug 24, 2023
| your repository. | ||
| the ``importmap.php`` file to point to it. You can either commit this directory | ||
| to your repository, or ignore the directory in your ``.gitignore`` config file. | ||
| If the directory is ignored, you can run the |
There was a problem hiding this comment.
Is it « can » or « must » ?
There was a problem hiding this comment.
I think in 6.4, we should change the workflow from "must commit" to "should ignore". Let's rework the language for that - it'll be just like composer install: it's a "must" (assuming you are downloading assets locally).
In fact, would you mind opening a new recipe PR for AssetMapper 6.4 that includes assets/vendor/ in .gitignore?
There was a problem hiding this comment.
While merging I did some tweaks according to your comments. See 5909e6b
OskarStark
changed the title
importmap:install command
|
@jmsche thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds docs for the new
importmap:installcommand added by symfony/symfony#51351.