Skip to content

[DependencyInjection] Add #[AutowireLocator] attribute #18775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

[DependencyInjection] Add #[AutowireLocator] attribute #18775

merged 1 commit into from
Aug 28, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #18774

@carsonbot carsonbot added this to the 6.4 milestone Aug 21, 2023
kbond
kbond suggested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alexandre-daubois!

service_container/service_subscribers_locators.rst Outdated
use Symfony\Component\DependencyInjection\Attribute\AutowireLocator;
use Symfony\Contracts\Service\ServiceSubscriberInterface;

class CommandBus implements ServiceSubscriberInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class CommandBus implements ServiceSubscriberInterface
class CommandBus

This should be removed, correct? (Same with below)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! That's updated 🙂

service_container/service_subscribers_locators.rst Outdated
use App\CommandHandler\FooHandler;
use Psr\Container\ContainerInterface;
use Symfony\Component\DependencyInjection\Attribute\AutowireLocator;
use Symfony\Contracts\Service\ServiceSubscriberInterface;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use Symfony\Contracts\Service\ServiceSubscriberInterface;

nicolas-grekas
nicolas-grekas reviewed Aug 22, 2023
View reviewed changes
service_container/service_subscribers_locators.rst Outdated
}

Just like with the ``getSubscribedServices()`` method, it is possible
to define aliased services thanks to named argument, as well as optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to define aliased services thanks to named argument, as well as optional
to define aliased services thanks to named arguments, as well as optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks 🙂

nicolas-grekas
nicolas-grekas reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@javiereguiluz
Copy link
Member

Another nice new feature and another perfect contribution. Thanks Alex ... and thanks to reviewers too!

@javiereguiluz javiereguiluz merged commit 3a2d65b into symfony:6.4 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] add #[AutowireLocator] attribute
5 participants
@alexandre-daubois @javiereguiluz @kbond @nicolas-grekas @carsonbot