Skip to content

[FrameworkBundle] Add AbstractController::renderBlock() and renderBlockView() #18766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

Fix #18764

templates.rst Outdated
}
}

This might come handy when dealing with :ref:`templates inheritance <template_inheritance-layouts>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it template inheritance or template block ?
Difference between extends and block need to be explicit imho
Anyway, that was documented fast 🚀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded a bit to mention blocks (which are mentioned in the inheritance doc), does it seem better?

@alexandre-daubois alexandre-daubois force-pushed the render-block-abstract-controller branch from 62eac54 to a945941 Compare August 21, 2023 09:37
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it is better indeed :)

@javiereguiluz javiereguiluz merged commit 6282451 into symfony:6.4 Aug 28, 2023
@javiereguiluz
Copy link
Member

Alex, thanks a lot for documenting this new feature!

Your contribution was perfect, but while merging we added a link to the AbstractController description for those who might need it: ebeb5ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] Add AbstractController::renderBlock() and `renderBl…
5 participants