[Process] Documented the new PhpSubprocess feature
#18693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
OskarStark
reviewed
Aug 7, 2023
OskarStark
changed the title
PhpSubprocess feature
|
This should be re-opened. This was accidentally closed by OskarStark/doctor-rst#1469 |
OskarStark
reviewed
Aug 8, 2023
OskarStark
reviewed
Aug 8, 2023
|
Should be good then :) |
javiereguiluz
force-pushed
the
phpsubprocess
branch
from
3968e10 to
1242610
Compare
|
Yanick, thanks a lot for this contribution. Your pull request was excellent ... but while reviewing it I felt that the tone didn't match most of the rest of the docs (the tone was a bit more appropriate for a blog post). So I reword it but keeping all your original meaning. I also merged the two examples and removed some text to make the new section a bit more concise. These are the full rewords: 89b0f58 Thanks! |
|
Perfect, thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18680