Skip to content

[Translation] Mention that default_locale is used as the default for framework.translator.fallbacks #18417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jun 15, 2023

I consider this relevant, since the current wording suggests that default_locale is for setting the default _locale value in the Request only – but, in fact, this setting also makes its way into the translator configuration.

@carsonbot carsonbot added this to the 5.4 milestone Jun 15, 2023
@carsonbot carsonbot changed the title Mention that default_locale is used as the default for framework.translator.fallbacks [Translation] Mention that default_locale is used as the default for framework.translator.fallbacks Jun 20, 2023
@OskarStark
Copy link
Contributor

Thank you Matthias.

@OskarStark OskarStark merged commit f5adf55 into symfony:5.4 Jun 20, 2023
@mpdude mpdude deleted the patch-2 branch June 20, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants