-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Security] Add caddy server configuration for Client Authentication (X509) #18151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How can I create a block definition for Caddy? Is it possible from this repository? |
Ping @francislavoie just in case of. |
Seems fine to me. Is the subject the only field someone might care about? Wouldn't they want the fingerprint and/or the full client cert as well potentially? Might want to point to Caddy's docs where it documents the placeholders for the client cert. Also FYI there's these Caddyfile placeholder shortcuts that can be used to shorten the config https://caddyserver.com/docs/caddyfile/concepts#placeholders |
Actually, in one of my project, I also use the fingerprint and other data you mentioned
But those additional ones are not required nor understood by the authenticator, that is why I did not add them in the documentation page. |
Might be worth mentioning it in case the user may need those additional fields for manual validation? You could put |
Indeed you are right. |
1ec8589
to
951a372
Compare
You could also switch to the short form as per my link. There's no downside to it. |
Many thanks 👌🏼. Done! |
Thanks Florent! This is now merged. |
The missing |
… (javiereguiluz) This PR was merged into the main branch. Discussion ---------- Add Caddy server config files to the list of known formats Here: symfony/symfony-docs#18151 we've merged a PR that uses `caddy` as a config format name. So, let's add support for it. Commits ------- ee62e63 Add Caddy server config files to the list of known formats
This PR adds a block to show how to configure Caddy Server.
Please note that this only works with SF6.3 (linked to #17582)