Skip to content

[Process] 📝 process: create_new_console is only for windows #18150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Process] 📝 process: create_new_console is only for windows #18150

merged 1 commit into from
Mar 31, 2023

Conversation

homersimpsons
Copy link
Contributor

cf: https://www.php.net/manual/en/function.proc-open.php

I find the current documentation a bit misleading because this option actually does nothing on non-Windows systems

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment

@carsonbot carsonbot changed the title 📝 process: create_new_console is only for windows [Process] 📝 process: create_new_console is only for windows Mar 31, 2023
@homersimpsons
Copy link
Contributor Author

@OskarStark Just applied your suggestion, everything should be ok now

@OskarStark OskarStark changed the base branch from 6.2 to 5.4 March 31, 2023 10:11
@OskarStark OskarStark requested a review from xabbuh as a code owner March 31, 2023 10:11
@OskarStark
Copy link
Contributor

Thank you @homersimpsons.

@OskarStark OskarStark merged commit aef616b into symfony:5.4 Mar 31, 2023
@homersimpsons homersimpsons deleted the patch-1 branch March 31, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants