Skip to content

[Translation] phrase translation provider #17861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

[Translation] phrase translation provider #17861

merged 1 commit into from
Aug 7, 2023

Conversation

wickedOne
Copy link
Contributor

@wickedOne wickedOne commented Feb 4, 2023 •
edited
Loading

documentation related to 49231

as you can see in the readme there's potentially some more documentation to add.

what would be the best way to proceed as adding all that to the translation.rst might be a bit much?

i see several options:

  • add everything but the config tables to the current tranlation.rst
  • leave it as is (think i touched on the most important parts) and refer to the readme of the provider
  • create a seperate documentation page for translation providers
  • leave it to the discovery of the developer as i think is done with the lokalise provider (given that one also creates locales on the fly)
  • ??

@carsonbot carsonbot added this to the 6.3 milestone Feb 4, 2023
This was referenced Feb 4, 2023
Merged
Merged
@xabbuh xabbuh modified the milestones: 6.3, next Feb 5, 2023
@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Feb 5, 2023
fabpot added a commit to symfony/symfony that referenced this pull request Aug 1, 2023
@fabpot
feature #49231 [Translation] Phrase translation provider (wickedOne)
489c887 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Translation] Phrase translation provider

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49142
| License       | MIT
| Doc PR        | symfony/symfony-docs#17861
| Recipe PR  | symfony/recipes#1172

Commits
-------

b8f35ba [Translation] Phrase translation provider
@carsonbot carsonbot changed the title phrase translation provider [Translation] phrase translation provider Aug 7, 2023
@javiereguiluz javiereguiluz modified the milestones: next, 6.4 Aug 7, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.3 to 6.4 August 7, 2023 07:51
@javiereguiluz javiereguiluz force-pushed the phrase-translation-provider branch from cf8d5ae to ea9b2a0 Compare August 7, 2023 07:51
@javiereguiluz javiereguiluz merged commit f3f6b6a into symfony:6.4 Aug 7, 2023
@javiereguiluz
Copy link
Member

@wickedOne thanks for this contribution!

About your questions: I think you did it perfectly. You mentioned Phrase and added some caution messages for the most important things where users can make mistakes (such as the language identificator format, etc.) All the rest is available in the README, so people can find it easily if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Translation
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@wickedOne @javiereguiluz @xabbuh @carsonbot