[Console] Add placeholder formatters per ProgressBar instance #17638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Jan 1, 2023
| $progressBar->setPlaceholderFormatter('countdown', function (ProgressBar $progressBar) { | ||
| return $progressBar->getMaxSteps() - $progressBar->getProgress(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We should probably add
.. versionadded:: 6.3
The ``setPlaceholderFormatter()`` method was introduced in Symfony 6.3.
There was a problem hiding this comment.
I thought of this, but wasn't sure! Do you know if there is any "rule" to it, when to add it or not?
There was a problem hiding this comment.
@alexandre-daubois we add the versionadded directive for any new option, method, class, feature, etc. added to Symfony. We also have the deprecated directive to do the opposite.
alexandre-daubois
force-pushed
the
progressbar-placeholder-formatter
branch
from
7f158ac to
54d88e1
Compare
OskarStark
approved these changes
Jan 2, 2023
|
Thanks Alexandre. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17545