[Security] Update locale with new authentication system #17595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
suggested changes
Oct 16, 2023
There was a problem hiding this comment.
Thanks for your PR @r-ant-2468
I think you can target 5.4 branch as it's already available in this version
session/locale_sticky_session.rst
Outdated
| @@ -148,8 +148,7 @@ event:: | |||
|
|
|||
| use Symfony\Component\EventDispatcher\EventSubscriberInterface; | |||
| use Symfony\Component\HttpFoundation\RequestStack; | |||
| use Symfony\Component\Security\Http\Event\InteractiveLoginEvent; | |||
| use Symfony\Component\Security\Http\SecurityEvents; | |||
| use Symfony\Component\Security\Http\Event\LoginSuccessEvent; | |||
There was a problem hiding this comment.
We also must update L144
To do this, you need an event subscriber on the
security.interactive_login
event::
carsonbot
changed the title
For the new authentication system, the LoginSuccessEvent event that is fired after logging in. This is to be updated in the new documentation
|
@r-ant-2468 thanks and congrats on your first Symfony Docs contribution 🎉 Sorry it took us so long to merge it. @alamirault thanks for the review. At the end we merged it in 6.3 and up because there were too many conflicts otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new authentication system, the LoginSuccessEvent event that is fired after logging in. This is to be updated in the new documentation