Symfony CLI: document the .symfony.local.yaml config file #17562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucksaun
reviewed
Dec 14, 2022
Comment on lines
+299
to
+303
| # Sets domain1.wip and domain2.wip for the current project | ||
| proxy: | ||
| domains: | ||
| - domain1 | ||
| - domain2 |
There was a problem hiding this comment.
I'm wondering if this should not be moved to the proxy section 🤔.
Basically pin every part of the YAML to its dedicated feature section.
There was a problem hiding this comment.
I'm open to move it if it's really wanted?
There was a problem hiding this comment.
After thinking about this, I think it's better for now to keep all options of the config file in the same section, because it's not very long. In any case, if we realize that this is not working well, we can quickly update this in a future PR to do what @tucksaun suggested.
|
Thank you @jmsche. |
javiereguiluz
force-pushed
the
symfony_cli_config_file
branch
from
1498387 to
4f17fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there are some other options available for the
.symfony.local.yamlconfiguration file: https://github.com/symfony-cli/symfony-cli/blob/862b631e07adc07a534ef5349cbffa6006b76f41/local/project/config.go#L34-L61I think this PR documents all of them :)