[Console][Testing] Correct what appears to be intended behavior vs actual behavior in do… #17559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cumentation When testing a command with an `InputOption::VALUE_NONE` option, and symfony/console v5.4.15 I have to provide a non-empty value to set the flag to the 'on' value. Perhaps this is changed in a later version?
wouterj
approved these changes
Feb 19, 2024
Co-authored-by: Wouter de Jong <wouterj@users.noreply.github.com>
carsonbot
changed the title
|
Good catch Tom! Thanks and congrats on your first (and nice) Symfony Docs contribution 🎉 Note: I'm closing this PR in favor of #19580, which contains the same commits but fixes the merge conflicts. Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 20, 2024
…ehavior vs actual behavior in documentation (tomegantcs) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Console][Testing] Correct what appears to be intended behavior vs actual behavior in documentation This continues #17559 because the original PR had some conflicts that I cannot fix while merging. I cherry-picked the original commits, so the contribution will go to the original author. Thanks! Commits ------- 2d2a1ce [Console][Testing] Correct what appears to be intended behavior vs actual behavior in documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cumentation
When testing a command with an
InputOption::VALUE_NONEoption, and symfony/console v5.4.15 I have to provide a non-empty value to set the flag to the 'on' value. Perhaps this is changed in a later version?