Add documentation about the Doctrine EntityValueResolver
#17393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
EntityValueResolver
OskarStark
reviewed
Oct 24, 2022
jderusse
force-pushed
the
entity-value-resolver
branch
from
dbb0f13 to
410e60b
Compare
OskarStark
reviewed
Oct 24, 2022
I think the "Automatically Fetching Objects (EntityValueResolver)" section in the doctrine guide would be a good place for this. If it gets very verbose (because of the many options), we might want to move it to a sub-guide under |
jderusse
force-pushed
the
entity-value-resolver
branch
from
410e60b to
36d91fe
Compare
|
Documentation about options added |
wouterj
reviewed
Nov 29, 2022
jderusse
commented
Dec 1, 2022
ker0x
reviewed
Dec 5, 2022
|
Hi @jderusse! Thanks for writing the bulk of these docs! I've fixed the remaining open comments and removed the "First, enable the feature" step as I believe this are now automatic. |
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Dec 6, 2022
* 6.2: Fix typo, change parameter $accesToken to $token Fix lint issues [symfony#17393] Finish entity value resolver docs [FrameworkBundle] Rename option `catch_all_throwables` to `handle_all_throwables` in documentation Add documentation about the Doctrine Entity Value Resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43854
This PR replaces the documentation about the Doctrine ParamterConverter by the new Entity ValueResolver.
It does not cover all the behaviors and possibilities. This was previously documented I the SensioFrameworkExtraBundle (https://symfony.com/bundles/SensioFrameworkExtraBundle/current/annotations/converters.html). I wonder where should I put such documentation for the EntityArgumentResolver ?