Add page about configuring the session TTL #16880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
session/configuring_ttl.rst
Outdated
| ->register(RedisSessionHandler::class) | ||
| ->setArguments([ | ||
| new Reference('Redis'), | ||
| ['ttl' => new Reference('my.ttl.handler')], |
There was a problem hiding this comment.
for php, don't we showcase the PHP DSL instead of the raw definition?
it would then be closure(service('bar'))
we don't have a shortcut for raw php, so the code is a bit long:
['ttl' => (new Definition('Closure'))->setFactory(['Closure', 'fromCallable'])->addArgument(new Reference('my.ttl.handler'))]There was a problem hiding this comment.
I have no idea here, have close to zero exp with PHP configs. I updated it to use PHP DSL, hope this works :)
nicolas-grekas
approved these changes
Jun 16, 2022
session/configuring_ttl.rst
Outdated
|
|
||
| $services | ||
| ->set(RedisSessionHandler::class) | ||
| ->arg('$redis', new Reference('Redis')) |
There was a problem hiding this comment.
->args([
new Reference('Redis'),
['ttl' => closure(service('my.ttl.handler'))],
])
(same above and below)
|
Jordi, thanks for this contribution! We know that creating an entirely new doc page takes some extra effort, so thanks for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16668
I need someone to help out with the callback config for the XML/PHP, I'm not sure it's correct (well the XML is not done at all, so pretty sure that's wrong). I could not find any info about
!callbackin the docs (cc @nicolas-grekas)