[Validator] Improve Image constraint invalid mime type message #16663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Maxime. |
|
It's a little bit more complicated than that.
|
|
Sorry for misunderstanding this new change, indeed I will correct this as soon as possible. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 26, 2022
…age option (mdoutreluingne) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [Validator] Fix of the description of the mime type message option In this PR, I corrected the mistake I made [here.](#16663) I used the table of parameters of the `File` constraint to explain the different parameters in the `Image` constraint. Can you do a review please? `@fancyweb` ready for review :) Commits ------- b557833 [Validator] Fix of the description of the mime type message option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16662
Changed the default message in case of incorrect mime type for the image constraint.
From 6.1 we will replace
This file is not a valid image.with thisThe mime type of the file is invalid ({{ type }}). Allowed mime types are {{ types }}..