[Form] Update form_collections.rst #15981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
xabbuh
approved these changes
Nov 19, 2021
form/form_collections.rst
Outdated
| @@ -531,7 +531,7 @@ First, add a "delete this tag" link to each tag form: | |||
|
|
|||
| .. code-block:: javascript | |||
|
|
|||
| const tags = document.querySelectorAll('ul.tags') | |||
| const tags = document.querySelectorAll('ul.tags.li') | |||
There was a problem hiding this comment.
Should this really be ul.tags.li or ul.tags li ?
Hi, Shouldn't we add a delete link just to <li> childs instead of the <ul> parent ? Thanks
|
Hi @Punt13140! Looking at the old jQuery version of this example (https://symfony.com/doc/4.4/form/form_collections#template-modifications), Javier is correct and it should have been Thank you for fixing bugs in the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I followed the instruction, and if you add a delete button to the
<ul>parent, you have a delete button with nolito delete.Thanks