Skip to content

Clarify how workflow can be injected #14106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Clarify how workflow can be injected #14106

wants to merge 4 commits into from

Conversation

epitre
Copy link
Contributor

@epitre epitre commented Aug 19, 2020

No description provided.

@epitre epitre mentioned this pull request Aug 19, 2020
Closed
@wouterj wouterj added the Waiting Code Merge Docs for features pending to be merged label Aug 19, 2020
@wouterj wouterj added this to the next milestone Aug 19, 2020
noniagriconomie
noniagriconomie reviewed Aug 20, 2020
View reviewed changes
@epitre epitre force-pushed the getWorkflowFromClass branch from 0a183ab to a99fd2b Compare August 28, 2020 21:28
@epitre
Copy link
Contributor Author

epitre commented Aug 28, 2020

@lyrixx good for you ?

lyrixx
lyrixx reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I felt a couple of comment.
Could you also change the PR title, because it does not reflect the PR anymore (the title is used to create the commit message)

@epitre epitre changed the title make ->get consistent with the doctrine way (by using class name) Make clear how workflow can be injected Sep 1, 2020
@epitre epitre changed the title Make clear how workflow can be injected Clarify how workflow can be injected Sep 1, 2020
@epitre epitre force-pushed the getWorkflowFromClass branch from 018b64c to 9e10527 Compare September 1, 2020 12:34
lyrixx
lyrixx approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Sep 8, 2020
Nyholm
Nyholm approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @epitre

This is great!

@wouterj
Copy link
Member

wouterj commented Oct 31, 2020

Thank you @epitre for your research on this topic and the time you put into sharing your findings with others! This PR is perfect :)

wouterj added a commit that referenced this pull request Oct 31, 2020
@wouterj
feature #14106 Clarify how workflow can be injected (epitre)
4cb6b21 
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead.

Discussion
----------

Clarify how workflow can be injected

Commits
-------

cb1a140 Clarify how workflow can be injected
@wouterj
Copy link
Member

wouterj commented Oct 31, 2020

Fyi, I've merged this PR in the 4.4 version of the docs and I'll bring it in newer version from there. This is why I cannot mark this PR as "merged". But here is the proof that your first doc contribution is a fact: 4cb6b21 :)

@wouterj wouterj closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@lyrixx lyrixx lyrixx approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
7 participants
@epitre @wouterj @lyrixx @Nyholm @noniagriconomie @javiereguiluz @carsonbot