Skip to content

[Process] Update process.rst #14005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

matthewtrask
Copy link
Contributor

This PR updates the text on the Process docs from "double brackets" which to a lot of people would mean [[]] to "double quotations" "" as demonstrated in the code example for the prepared statement.

@mattstauffer
Copy link

@matthewtrask Oops, I duplicated this; #14006

Yours is probably in the right branch, but mine has more changes. Would you mind reviewing mine and either adding my changes to your PR so I can close mine (assuming you got the right branch and I didn't) and then I can close mine? Thanks!

@matthewtrask
Copy link
Contributor Author

@mattstauffer I looked to see if there was already a PR, I think we opened them at the same time :)

I brought your changes in here, which was better than what I added. I will default to the maintainers on which branch is better to keep open.

@javiereguiluz
Copy link
Member

Matt (@matthewtrask), thanks a lot for this contribution! (and thanks to Matt (@mattstauffer) too for his contributions in the other pull request).

I'm sorry this fell off our radar and took us so long to merge. It's finally merged!

@javiereguiluz javiereguiluz merged commit 36eafb7 into symfony:5.1 Sep 25, 2020
@matthewtrask
Copy link
Contributor Author

@javiereguiluz its all good, thanks for the message :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants