Shortening the "Prototype" paragraph #13445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Thomas. We made two minor changes when merging this. We replace all the "we" and "our" occurrences because that's against the writing style in the docs (we always use "you" and "your"). Second, we readded the explicit mention to |
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Apr 4, 2020
Reason: If you read "How to Embed a Collection of Forms" at https://symfony.com/doc/3.4/forms.html#learn-more it doesn't really reveal what this is all about. So I changed the title to something which describes it better from the user's point of view. I also removed all occurrences of "you" in the first paragraph, see symfony#13445 (comment)
javiereguiluz
added a commit
that referenced
this pull request
Dec 22, 2020
This PR was submitted for the 3.4 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [Form] Renaming the article Reason: If you read "How to Embed a Collection of Forms" at https://symfony.com/doc/3.4/forms.html#learn-more it doesn't really reveal what this is all about. So I changed the title to something which describes it better from the user's point of view. I also removed all occurrences of "you" in the first paragraph, see #13445 (comment) Commits ------- e9cc299 [Form] Renaming the article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.