Fix invalid yaml #12880
Merged
Fix invalid yaml #12880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 2, 2020
xabbuh
approved these changes
Jan 2, 2020
|
@jschaedl thanks for fixing this issue and thanks for the detailed explanation! |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2020
This PR was merged into the 4.3 branch. Discussion ---------- Fix invalid yaml Because `deprecated: 'The "%alias_id%" alias is deprecated. Don\'t use it anymore.'` is not valid Yaml, it leads to this error: [OK] All 1 YAML files contain valid syntax. >> Unexpected characters near "t use it anymore. The yaml specification says: > All non-printable characters must be escaped. YAML escape sequences use the “\” notation common to most modern computer languages. Each escape sequence must be parsed into the appropriate Unicode character. The original escape sequence is a presentation detail and must not be used to convey content information. > Note that escape sequences are only interpreted in double-quoted scalars. In all other scalar styles, the “\” character has no special meaning and non-printable characters are not available. So I think removing the `'` will help users who copy the configuration from the documentation. Commits ------- 84151dc Fix invalid yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
deprecated: 'The "%alias_id%" alias is deprecated. Don\'t use it anymore.'is not valid Yaml, it leads to this error:[OK] All 1 YAML files contain valid syntax.
The yaml specification says:
So I think removing the
'will help users who copy the configuration from the documentation.