-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Getting product using Symfony autowiring #12456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Nov 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, but I would shorten the example a bit
OskarStark
requested changes
Dec 12, 2019
OskarStark
approved these changes
Dec 24, 2019
Thank you and merry Christmas 🎄 |
thanks you @OskarStark , merry christmas too 😉 |
@abdounikarim we finally merged this! I'm sorry for being so late. Thank you! |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2020
This PR was squashed before being merged into the 4.3 branch (closes #12456). Discussion ---------- Getting product using Symfony autowiring Hello, I add a code block to get product using Symfony autowiring and DependencyInjection. Do you think it's useful ? Cheers 😉 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1b92a9f Getting product using Symfony autowiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I add a code block to get product using Symfony autowiring and DependencyInjection.
Do you think it's useful ?
Cheers 😉