[Messenger] Added an implementation to the TransportInterface #12340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
force-pushed
the
issue-12230-TransportInterface
branch
from
b9a7fde to
57b7da2
Compare
weaverryan
reviewed
Sep 18, 2019
|
Thank you for the feedback. PR is updated |
|
@Nyholm thanks a lot for this contribution! Should this be merged in 4.3 or 4.4? Thanks. |
|
I just checked. We can merge this into 4.3. |
javiereguiluz
force-pushed
the
issue-12230-TransportInterface
branch
from
be6af0e to
e1c669b
Compare
|
Nice addition Tobias! It's merged (in 4.3) now. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 19, 2019
…rface (Nyholm) This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes #12340). Discussion ---------- [Messenger] Added an implementation to the TransportInterface This will fix #12230 This is basically a much simpler `DoctrineTransport` with easy query builders and no real error handling. Commits ------- e1c669b [Messenger] Added an implementation to the TransportInterface
|
Thank you for merging. |
|
@Nyholm Thanks a lot for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #12230
This is basically a much simpler
DoctrineTransportwith easy query builders and no real error handling.