Skip to content

[Routing] Better explain the config needed for routing annotations #12336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

[Routing] Better explain the config needed for routing annotations #12336

merged 1 commit into from
Sep 19, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #12218.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 18, 2019
@javiereguiluz javiereguiluz mentioned this pull request Sep 18, 2019
Closed
linaori
linaori approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added configuration example as provided by flex is really nice!

javiereguiluz added a commit that referenced this pull request Sep 19, 2019
@javiereguiluz
minor #12336 [Routing] Better explain the config needed for routing a…
3f12092 
…nnotations (javiereguiluz)

This PR was squashed before being merged into the 4.3 branch (closes #12336).

Discussion
----------

[Routing] Better explain the config needed for routing annotations

Fixes #12218.

Commits
-------

790b04c [Routing] Better explain the config needed for routing annotations
@javiereguiluz javiereguiluz merged commit 790b04c into symfony:4.3 Sep 19, 2019
@javiereguiluz javiereguiluz deleted the fix_12218 branch September 19, 2019 07:39
xabbuh added a commit that referenced this pull request Sep 19, 2019
@xabbuh
[#12336] fix a minor typo
c7d22b6
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Sep 19, 2019
@javiereguiluz
Merge branch '4.3' into 4.4
ea387cd 
* 4.3:
  Minor fix
  Add note on Apache issue with FallbackResource
  [symfony#12336] fix a minor typo
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Sep 19, 2019
@javiereguiluz
Merge branch '4.4'
1bbd804 
* 4.4:
  Minor fix
  Add note on Apache issue with FallbackResource
  [symfony#12336] fix a minor typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linaori linaori linaori approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @linaori @carsonbot