[Logger] [Processor] additional info on processor #11825
Conversation
noniagriconomie
changed the title
noniagriconomie
changed the title
There was a problem hiding this comment.
There’s some good stuff here :).
About your question: Monolog is still maintained, but yea, Jordi (the main maintainer is quite busy). It is a library that we “sorta” consider a responsibility of Symfony and we do discuss keeping it maintained. I don’t think there are plans to bring it into Symfony, but we should make sure it’s getting the attention it needs.
What made you think it was abandoned? Just lack of activity?
| only for a specific handler. | ||
| Monolog allows you to process every record before logging it by adding some | ||
| extra data. This is the role of a processor, which can be applied for the whole | ||
| handler stack or only for a specific handler or channel. |
|
@weaverryan Thank for your reply
I did not write Just wanted to ask while opening this PR I will address your review soon :) |
|
hi @weaverryan PR is updated accordingly, ready for review :) |
|
friendly ping @weaverryan |
|
@noniagriconomie could you please rebase your PR, I had some issues while merging it and give me a ping? |
noniagriconomie
force-pushed
the
patch-3
branch
from
b7a7f10 to
40004f8
Compare
|
@OskarStark ping, here you are :) EDIT: for the part on the Monolog question
Monolog release https://github.com/Seldaek/monolog/releases/tag/2.0.0, so maybe the question is no more important :) |
javiereguiluz
force-pushed
the
patch-3
branch
from
40004f8 to
38f5ed7
Compare
…griconomie) This PR was squashed before being merged into the 4.3 branch (closes #11825). Discussion ---------- [Logger] [Processor] additional info on processor Hi, I was reading doc around log/monolog and testing some features (processor here). I think this is an addition to have in the doc. Edit : I also have a question, I can see that monolog, which is the main php logger lib, is not "actively maintained", maybe the maintainer(s) are busy on other projects which is normal Question is: do you think it can be included as it is as a symfony component ? so that it can get more visibility/documentation and so community maintainers just asking like that :) Commits ------- 38f5ed7 [Logger] [Processor] additional info on processor
|
Thanks Antoine. This is merged now! |
Hi,
I was reading doc around log/monolog and testing some features (processor here).
I think this is an addition to have in the doc.
Edit :
I also have a question, I can see that monolog, which is the main php logger lib, is not "actively maintained", maybe the maintainer(s) are busy on other projects which is normal
Question is: do you think it can be included as it is as a symfony component ? so that it can get more visibility/documentation and so community maintainers
just asking like that :)