Skip to content

Added a missing redirection for a deleted article #11785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

javiereguiluz
Copy link
Member

@linaori reported on Symfony Slack that some Google result has a link to https://symfony.com/doc/4.1/profiler/storage.html, which no longer exists (it existed in 3.4 and before).

Apparently we forgot to add the redirection when we removed this page. We can't fix 4.1 (because that branch is no longer supported), but at least we can fix it in 4.2 and later.

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jun 19, 2019
@OskarStark
Copy link
Contributor

Is it not possible to fix sth like this via a hotfix for the older branches? Could be a separate PR. Because having google results as 404 is bad 🥺

@javiereguiluz javiereguiluz merged commit f0a565d into symfony:4.2 Jun 20, 2019
javiereguiluz added a commit that referenced this pull request Jun 20, 2019
…reguiluz)

This PR was merged into the 4.2 branch.

Discussion
----------

Added a missing redirection for a deleted article

@linaori reported on Symfony Slack that some Google result has a link to https://symfony.com/doc/4.1/profiler/storage.html, which no longer exists (it existed in 3.4 and before).

Apparently we forgot to add the redirection when we removed this page. We can't fix 4.1 (because that branch is no longer supported), but at least we can fix it in 4.2 and later.

Commits
-------

f0a565d Added a missing redirection for a deleted article
@javiereguiluz
Copy link
Member Author

I've edited the _build/redirection_map files for 4.0 and 4.1 branches directly on GitHub repository, so this should be fixed for them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants