Skip to content

[Forms] Reworded the article about creating custom form types #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

javiereguiluz
Copy link
Member

The new contents are completely different from the original ones, so you may prefer to review this by reading the rendered result: https://github.com/javiereguiluz/symfony-docs/blob/7bbd69e56621f450f5ca0e2fd78e397e0abbf947/form/create_custom_field_type.rst

Copy link
Contributor

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. I very much like the idea of using a concrete example. Sometimes going that way can mean you don't show every option, but I think it makes it much easier to understand 👍

@javiereguiluz javiereguiluz merged commit ac08120 into symfony:4.2 Jun 28, 2019
javiereguiluz added a commit that referenced this pull request Jun 28, 2019
…types (javiereguiluz)

This PR was squashed before being merged into the 4.2 branch (closes #11765).

Discussion
----------

[Forms] Reworded the article about creating custom form types

The new contents are completely different from the original ones, so you may prefer to review this by reading the rendered result: https://github.com/javiereguiluz/symfony-docs/blob/7bbd69e56621f450f5ca0e2fd78e397e0abbf947/form/create_custom_field_type.rst

Commits
-------

ac08120 [Forms] Reworded the article about creating custom form types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants