Skip to content

Clarify some words about simple-phpunit #11757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

nicolas-grekas
Copy link
Member

Could be worth porting to 3.4 too?

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to a code issue by clarifying the documentation!

If there are no merge conflicts/changes in 3.4, I propose to merge in 3.4 directly. Otherwise, 4.3 is fine (current is what most people read I think)

``prophecy`` to prevent any conflicts with these dependencies.
* Provides a modified version of PHPUnit that allows 1. separating the
dependencies of your app from those of phpunit to prevent any unwanted
constraints to apply; 2. running tests in parallel when a test suite is split
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this, parallelizing tests, could be highlighted more? Do you think it's worth adding a small section to this page giving a brief introduction why it's useful and how it works? If so, I could make a PR when I have some time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice indeed, I was totally unaware of that one...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrumann this has been merged, but it'd be nice to add a short section about parallelizing tests. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do an additional PR maybe this weekend.

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jul 5, 2019
@javiereguiluz javiereguiluz changed the base branch from 4.3 to 4.2 July 5, 2019 07:11
@javiereguiluz
Copy link
Member

Thanks Nicolas! Merged in 4.2.

@javiereguiluz javiereguiluz merged commit f4499c5 into symfony:4.2 Jul 5, 2019
javiereguiluz added a commit that referenced this pull request Jul 5, 2019
This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #11757).

Discussion
----------

Clarify some words about simple-phpunit

Could be worth porting to 3.4 too?

Commits
-------

f4499c5 Clarify some words about simple-phpunit
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 29, 2019
This PR was squashed before being merged into the 3.4 branch (closes symfony#11955).

Discussion
----------

Adds section on parallelizing tests.

See discussion in symfony#11757

Commits
-------

ddd5f05 Adds section on parallelizing tests.
@nicolas-grekas nicolas-grekas deleted the phpunit++ branch September 4, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants