Don't mention the Symfony Standard edition in the contributing docs #11712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boite
reviewed
Jun 10, 2019
boite
reviewed
Jun 10, 2019
boite
suggested changes
Jun 10, 2019
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
|
We usually only show the link the first time something is included in the article ... but these "skeletons" are still not well-known by lots of people, so let's include the links always. Thanks. |
boite
suggested changes
Jun 10, 2019
There was a problem hiding this comment.
Whoops! Sorry for making you do more work; one more change for the sake of consistency. I've read through the document in full this time. Looks great! Thank you @javiereguiluz.
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
boite
approved these changes
Jun 11, 2019
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2019
…buting docs (javiereguiluz) This PR was squashed before being merged into the 4.2 branch (closes #11712). Discussion ---------- Don't mention the Symfony Standard edition in the contributing docs Fixes #11692. Commits ------- f5f339c Don't mention the Symfony Standard edition in the contributing docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11692.