Skip to content

[HttpClient] improve doc again #11650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

[HttpClient] improve doc again #11650

merged 1 commit into from
Jun 4, 2019

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 3, 2019 •
edited by javiereguiluz
Loading

Fixes all todos and more :)

fixes #11530.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 3, 2019
javiereguiluz
javiereguiluz approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏 I left some minor comments. Thanks!

wouterj
wouterj approved these changes Jun 3, 2019
View reviewed changes
andreia
andreia suggested changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@andreia andreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for documenting this :)
( I just made some tweaks to the cheat sheet also based on your update, thank you! :) )

@javiereguiluz javiereguiluz merged commit f9339a3 into symfony:4.3 Jun 4, 2019
javiereguiluz added a commit that referenced this pull request Jun 4, 2019
@javiereguiluz
minor #11650 [HttpClient] improve doc again (nicolas-grekas)
31cbd03 
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] improve doc again

Fixes all todos and more :)

fixes #11530.

Commits
-------

f9339a3 [HttpClient] improve doc again
@javiereguiluz
Copy link
Member

Nicolas, thanks a lot for contributing these improvements. Thanks to reviewers too, specially Andréia ... I fixed all the typos you reported while merging. Thanks!

@nicolas-grekas nicolas-grekas deleted the hc++ branch June 4, 2019 12:22
@andreia
Copy link
Contributor

andreia commented Jun 4, 2019

Thank you Javier! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreia andreia andreia requested changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @javiereguiluz @andreia @wouterj @carsonbot