Skip to content

[serializer] document DEEP_OBJECT_TO_POPULATE #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

[serializer] document DEEP_OBJECT_TO_POPULATE #11344

merged 1 commit into from
Apr 7, 2019

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Apr 7, 2019

Document the new feature added in symfony/symfony#30607

@dbu dbu mentioned this pull request Apr 7, 2019
Merged
@xabbuh xabbuh added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
xabbuh
xabbuh approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with minor comments

@xabbuh xabbuh added this to the 4.3 milestone Apr 7, 2019
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Apr 7, 2019
@wouterj wouterj merged commit 7ea06fa into symfony:master Apr 7, 2019
wouterj added a commit that referenced this pull request Apr 7, 2019
@wouterj
feature #11344 [serializer] document DEEP_OBJECT_TO_POPULATE (dbu)
bda85fa 
This PR was merged into the master branch.

Discussion
----------

[serializer] document DEEP_OBJECT_TO_POPULATE

Document the new feature added in symfony/symfony#30607

Commits
-------

7ea06fa document DEEP_OBJECT_TO_POPULATE
wouterj added a commit that referenced this pull request Apr 7, 2019
@wouterj
[#11344] Some minor formatting changes
fed4d14
@wouterj
Copy link
Member

wouterj commented Apr 7, 2019

Thank you @dbu! I've done a couple changes (mostly moving stuff out of the versionadded) in fed4d14 . Let me know if you disagree with anything.

@dbu
Copy link
Contributor Author

dbu commented Apr 8, 2019 •
edited
Loading

ah, cool! the way you edited it is much better because we can remove the versionadded thing without rewriting any of the rest. i was afraid of people on older versions reading the doc and not noticing that its about a new feature, but if doc is written the way you edited it, its better readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Serializer Status: Reviewed Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@dbu @wouterj @xabbuh @OskarStark @carsonbot