Skip to content

Add docs for the yaml env var processor #11321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Apr 6, 2019

For symfony/symfony#30910. Based on the file/json examples.

#FOSSHackathon

@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
# config/services.yaml
parameters:
env(SECRETS_FILE): '/opt/application/.secrets.yaml'
database_password: '%env(key:database_password:yaml:file:SECRETS_FILE)%'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we change the example and remove the key:database_password processor here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark To make the example more concise?

Would you ever use an array value as such?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure, I haven’t any other example

@OskarStark OskarStark added Dotenv Waiting Code Merge Docs for features pending to be merged labels Apr 6, 2019
@xabbuh xabbuh added this to the next milestone Apr 6, 2019
@mpdude
Copy link
Contributor Author

mpdude commented Apr 6, 2019

Closing as @nicolas-grekas and I agreed that symfony/symfony#30910 is not worthwhile.

@mpdude mpdude closed this Apr 6, 2019
@mpdude mpdude deleted the docs-for-30910 branch April 6, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dotenv ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants