Skip to content

Removed interface #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removed interface #10538

wants to merge 1 commit into from

Conversation

Gasjki
Copy link

@Gasjki Gasjki commented Oct 23, 2018

You don't have to use that interface for this case. Even if you add it, you need to implement getSubscribedEvents() method.

@Gasjki
Removed interface
0bfdd66 
You don't have to use that interface for this case. Even if you add it, you need to implement `getSubscribedEvents()` method.
@xabbuh
Copy link
Member

xabbuh commented Oct 24, 2018

Thank you for this proposition @Gasjki. In fact I would prefer to fix the PHP code instead so that we do not have to create an extra service definition manually (see #10546).

@javiereguiluz
Copy link
Member

Closing in favor of #10546. @Gasjki even if your pull request wasn't merged, it helped us discover (and fix) an issue in the current docs. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gasjki @xabbuh @javiereguiluz @carsonbot