[Console] Replace useless usage of ContainerAwareCommand #10219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Aug 24, 2018
|
Good catch, thanks @gregurco. |
xabbuh
added a commit
that referenced
this pull request
Aug 24, 2018
… (gregurco) This PR was merged into the 4.1 branch. Discussion ---------- [Console] Replace useless usage of ContainerAwareCommand Hello. Since SF 4.0 there is no need to use `ContainerAwareCommand` and injection through constructor. I removed usage of `ContainerAwareCommand` and added call of parent `constructor` because there is an error without it: ``` [WARNING] Some commands could not be registered: Command class "App\Command\CommandName" is not correctly initialized. You probably forgot to call the parent constructor. ``` Commits ------- 0d1696c [Console] Replace useless usage of ContainerAwareCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Since SF 4.0 there is no need to use
ContainerAwareCommandand injection through constructor. I removed usage ofContainerAwareCommandand added call of parentconstructorbecause there is an error without it: