Skip to content

opcode optimizations #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

opcode optimizations #10147

wants to merge 1 commit into from

Conversation

matt9mg
Copy link
Contributor

@matt9mg matt9mg commented Aug 3, 2018

Using '\get_class(...)' would enable some of the opcode optimizations and result in fewer lookups.

@matt9mg
opcode optimizations
782f261 
Using '\get_class(...)' would enable some of the opcode optimizations and result in fewer lookups.
@xabbuh xabbuh added this to the 2.8 milestone Aug 3, 2018
@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2018

This is in line with the code: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Validator/Constraint.php#L275-L278

@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2018

Thank you @matt9mg.

xabbuh added a commit that referenced this pull request Aug 3, 2018
@xabbuh
minor #10147 opcode optimizations (matt9mg)
8247d44 
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10147).

Discussion
----------

opcode optimizations

Using '\get_class(...)' would enable some of the opcode optimizations and result in fewer lookups.

Commits
-------

a5e1f90 opcode optimizations
@xabbuh xabbuh closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@matt9mg @xabbuh @carsonbot