Service container docs, reference section #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additions to the glossary.
… is a less-scary name and more descriptive. Also proofreading.
| The service container is built using a single configuration resource | ||
| (``app/config/config.yml`` by default). All other service configuration( | ||
| (including the core Symfony2 and third-party bundle configuration) must | ||
| be imported form inside this file in one way or another. This gives you absolute |
There was a problem hiding this comment.
form seems an error in this sentence.
There was a problem hiding this comment.
Good catch - this is fixed now.
|
Definitely a good read for beginners, great job Ryan! I've seen one or two minor typos, but that's basically all I can criticize. |
|
Great, thanks for looking through it! For the typos you see, if you do a line comment, I'll fix them up - somehow you can never catch all of your mistakes. |
| .. tip:: | ||
|
|
||
| Be sure that ``swift_mailer.config`` entry appears in your application | ||
| configuration. As we mentioned in :ref:`service-container-extension-configuration`, |
There was a problem hiding this comment.
It's swiftmailer.config, not swift_mailer.config :)
|
I've just added some suggestions here and there but overall, the chapter is excellent. Thanks! |
… typos and making a few other changes: * Adding more information on what makes a PHP object a service and more on the DIC exension providing semantic configuration for the bundle. * Reworking the docs so that I don't show an empty ``app.config``.
… from other objects.
xabbuh
pushed a commit
that referenced
this pull request
Jul 28, 2016
… (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #101). Discussion ---------- Update some screenshots to wrap them with a browser window This change just adds a CSS class to the generated `<div>` element that wraps images. Commits ------- 38bb120 Update some screenshots to wrap them with a browser window
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes
Comments welcomed :)