Skip to content

Commit

Permalink
minor #4697 Set twig service as private (ifdattic)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.3 branch.

Discussion
----------

Set twig service as private

During the best practices workshop it was suggested that it's best to set services to private if they won't be accessed from your code/container (for performance reasons)

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Commits
-------

7427051 Set twig service as private
  • Loading branch information
weaverryan committed Jan 3, 2015
2 parents 09f9d3d + 7427051 commit aa9d982
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions best_practices/templates.rst
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ name is irrelevant because you never use it in your own code):
app.twig.app_extension:
class: AppBundle\Twig\AppExtension
arguments: ["@markdown"]
public: false
tags:
- { name: twig.extension }
Expand Down

0 comments on commit aa9d982

Please sign in to comment.