Skip to content

Commit

Permalink
minor #3645 Adjusted the BC rules to be consistent (stof)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.3 branch.

Discussion
----------

Adjusted the BC rules to be consistent

A previous rule states that we guarantee BC for code extending the class. This rules does not allow marking a class as final as it would be a fatal error for extending code after the upgrade, which is far from being BC.

/cc @fabpot @webmozart

Commits
-------

6c1ded9 Adjusted the BC rules to be consistent
  • Loading branch information
weaverryan committed Mar 7, 2014
2 parents 664a0be + 6c1ded9 commit 2ed0943
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contributing/code/bc.rst
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ Symfony's classes:
Type of Change Regular API
================================================== ============== ==============
Remove entirely No No
Make final Yes [2]_ No
Make final No No
Make abstract No No
Change name or namespace No No
Change parent class Yes [7]_ Yes [7]_
Expand Down

0 comments on commit 2ed0943

Please sign in to comment.