Add workflow to verify dist build #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chapterjason! This IS something we need to prevent. But actually, the proper solution is to commit NOT dist files and to build them on release - we were talking about it recently here: #15 (comment) So, if you're interesting, I think that would be awesome to properly have :). We can work in including less dist files (another topic of that thread) in another PR after a few recent PR's are merged. Thanks! |
|
@weaverryan You are absolutely right. We should not build up too much technical debt. Closing this then. An issue for discussion would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow builds the plugin and check if there are any git changes, if so the the build will fail.
This ensures that the dist output will always be the latest.